fs2open.github.com icon indicating copy to clipboard operation
fs2open.github.com copied to clipboard

Bug: Unequippable weapons for specific banks showing as equippable.

Open jlberman opened this issue 1 year ago • 6 comments

In ships.tbl, there's only one weapon that can be equipped in the first bank of this ship.

image

Click that bank in the weapon loadout room, and the loadout room shows that you can equip those weapons in that bank.

image

But when you try to drag an invalid weapon into that bank, it gives you an error.

screen0249

It should grey out invalid banks in the UI when you can't load a particular weapon into a particular bank.

Note to @Goober5000 : This can be replicated in Inferno M14.

jlberman avatar Oct 16 '24 20:10 jlberman

Unless this situation plays out differently in a past version of FSO, I think this is not really a bug. If memory serves, outside of some bomb slots retail doesn't do a lot with having different compatibility for different banks, so the UI just isn't designed to react like that. I'm willing to be wrong if you can point to a scenario where it does re-actively grey out weapons based on bank selection, or did in a past version.

EatThePath avatar Oct 18 '24 19:10 EatThePath

Oh, OK. So this is really a feature request, then?

jlberman avatar Oct 18 '24 19:10 jlberman

Oh, OK. So this is really a feature request, then?

Yes, probably. Though I think it's also a feature mods can probably implement with Lua these days, too.

EatThePath avatar Oct 18 '24 20:10 EatThePath

This does work in SCPUI out of the box.

MjnMixael avatar Oct 19 '24 16:10 MjnMixael

Interesting, if manually created icons are used instead (such as eff image sequences for the icons) then they properly show as greyed out. I wonder if this feature just never made it over to the generated icons feature?

wookieejedi avatar Oct 19 '24 17:10 wookieejedi

Hmm. It's entirely possible that updates were made to one part of the UI but not another part. There have been many updates over the years, and it's not uncommon for an upgrade in one part of the code to miss a very similar case elsewhere in the code.

Goober5000 avatar Oct 19 '24 17:10 Goober5000

Yeah, because in retail it does grey out those things.

jlberman avatar Oct 31 '24 16:10 jlberman