Guillaume Giudicelli
Guillaume Giudicelli
@socratesgorilla I already opened a PR for that. The issue is coverage went down, so there are some tests missing when you remove the mesh modifiers https://github.com/idaholab/moose/pull/20845 You're welcome to...
nice. I m happy to close the other one if we have all that was there. @lindsayad who was reviewing the other one or myself will look at this one.
Coverage does not show the whole picture. These tests were likely designed to test a capability, not a line of code. Capabilities are much more important to test than lines...
Sounds good. Sorry for the delay in reviewing.
There are a ton of MooseUtils we should just link to the doxygen at this point
This PR does change all the input files from args to variable_names. I m not sure if variable_names is the best name. It s the best for ParsedMaterial for sure...
haha I like all these choices I m ok with changing everything if I can get consensus from the phase field community for this args is confusing as soon as...
I took care of this last thing. I do think if we rename parameters we should do it in one go, not make multiple PRs. `vars` is problematic I agree...
how about constant_args instead of vars?