moose icon indicating copy to clipboard operation
moose copied to clipboard

Support Ring and Sector ID option in TriPinHexAssemblyGenerator (Reactor Module)

Open yjung-anl opened this issue 2 years ago • 6 comments

closes #21908

yjung-anl avatar Aug 20 '22 18:08 yjung-anl

Job Documentation on 3145588 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild avatar Aug 20 '22 20:08 moosebuild

Job Coverage on 3145588 wanted to post the following:

Framework coverage

993b03 #21909 314558
Total Total +/- New
Rate 84.30% 84.31% +0.00% -
Hits 80166 80167 +1 0
Misses 14925 14924 -1 0

Diff coverage report

Full coverage report

Modules coverage

Reactor

993b03 #21909 314558
Total Total +/- New
Rate 95.76% 95.79% +0.03% 95.00%
Hits 3796 3820 +24 57
Misses 168 168 - 3

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

moosebuild avatar Aug 20 '22 20:08 moosebuild

Job App documentation on 7adc290 : invalidated by @yjung-anl

moosebuild avatar Aug 22 '22 13:08 moosebuild

@GiudGiud Thank you for your review. I will address your comments very soon

yjung-anl avatar Oct 10 '22 16:10 yjung-anl

Sounds good. Sorry for the delay in reviewing.

GiudGiud avatar Oct 11 '22 04:10 GiudGiud

Review comments were addressed

yjung-anl avatar Oct 11 '22 20:10 yjung-anl

Comments were addressed

yjung-anl avatar Oct 13 '22 19:10 yjung-anl

@GiudGiud Thank you for your efforts on this PR!!

yjung-anl avatar Oct 15 '22 04:10 yjung-anl