moose
moose copied to clipboard
idaholab
Replace XMLDiff and JSONDiff with new universal differ
Closes #21532
This will break falcon and isopod until we can update their tests with the new differ, so we will need to do some repointing in those repos when this PR is approved to be merged in.
Job Precheck on 311310e wanted to post the following:
A change of the following file(s) triggered this check:
conda/tools
The following file(s) are unchanged:
conda/mpich/conda_build_config.yaml
The conda build config was not changed but one or more of its dependencies have changed
Job Precheck on 962a433 wanted to post the following:
A change of the following file(s) triggered this check:
conda/tools
The following file(s) are unchanged:
conda/mpich/conda_build_config.yaml
The conda build config was not changed but one or more of its dependencies have changed
Job Precheck on eafac3d wanted to post the following:
A change of the following file(s) triggered this check:
conda/tools
The following file(s) are unchanged:
conda/mpich/conda_build_config.yaml
The conda build config was not changed but one or more of its dependencies have changed
Job Documentation on 17fe732 wanted to post the following:
View the site here
This comment will be updated on new commits.
Job Coverage on 17fe732 wanted to post the following:
Framework coverage
Coverage did not change
Modules coverage
Coverage did not change
Full coverage reports
Reports
-
framework -
chemical_reactions -
combined -
contact -
electromagnetics -
external_petsc_solver -
fluid_properties -
fsi -
functional_expansion_tools -
geochemistry -
heat_conduction -
level_set -
misc -
navier_stokes -
optimization -
peridynamics -
phase_field -
porous_flow -
ray_tracing -
rdg -
reactor -
richards -
scalar_transport -
solid_properties -
stochastic_tools -
tensor_mechanics -
thermal_hydraulics -
xfem
This comment will be updated on new commits.
I guess this is ready to go after preparing the patch for the applications using JSONDiff? Another alternative is to still keep both JSONDiff and XMLDiff, and just let them call SchemaDiff. This could be a valid option because we might need to do some custom operations differently for JSON and XML.
The message for the second commit is a bit long. I guess it is accidental, thus suggest to reword it.
We need a better name than SchemaDiff ? XML and JSON are both hierarchic right, is there any other characteristic which could be used for the name
We need a better name than SchemaDiff ? XML and JSON are both hierarchic right, is there any other characteristic which could be used for the name
Are they not both schema languagess? The only other thing I could see would be MarkupDiff or DataDiff.
Additionally, changing the name now would require rewriting 60 or so tests again to use the new name. If possible, I'd prefer to avoid it.
I've suggested to keep the original names. Their codes could be the same but if they name differently, I assume in the future there could be differences in the differ codes. I am not familiar with Python, but in c++, we can just derive two new classes. If a python package is used for this, I guess there could be an option for doing settings differently for XML and GSON? If we keep the original names, we will not break any applications.
Rewriting tests should be done with scripts btw, you should never do this manually.
I have never heard about schema languages but that's probably just my ignorance. @loganharbour @permcody you familiar with that?
@socratesgorilla where are we on this? Have you patched all the apps?
Yaqi's idea of keeping the old names is good. SchemaDiff is not as intuitive as JSONDiff or XMLDiff, we can just map the new names to the old name
Only failing app is falcon, and only one test. Could be fixed fairly easily with coordinated effort. Been waiting for a discussion for what to do on this.
I suppose it could be changed into both JSONDiff and XMLDiff if necessary. Would avoid having to change falcon at least.
Job Precheck on a291b99 wanted to post the following:
A change of the following file(s) triggered this check:
conda/tools
The following file(s) are unchanged:
conda/mpich/conda_build_config.yaml
The conda build config was not changed but one or more of its dependencies have changed
Unfortunately Peter is out on travel and he is sort of the spearhead of this libtorch stochastic tools stuff that is failing. It is failing legitimately, the differ is accurately detecting a difference larger than the accepted error, so something is wrong there.
The falcon issue is completely mindboggling. The diff it creates could not be replicated locally, and its totally unclear why the new json output is using "unsigned long" instead of "unsigned long long" like in the gold file. If anyone has any guidance on it, that would be ideal.
Job Precheck on 8861ba9 wanted to post the following:
The following commit(s) contain fixups:
- 8861ba95823: fixup! Deleted remaining old differ files, fixed relative error to work as intended
Job Precheck on 8861ba9 wanted to post the following:
A change of the following file(s) triggered this check:
conda/tools
The following file(s) are unchanged:
conda/mpich/conda_build_config.yaml
The conda build config was not changed but one or more of its dependencies have changed
Job Precheck on 528efb0 wanted to post the following:
A change of the following file(s) triggered this check:
conda/tools
The following file(s) are unchanged:
conda/mpich/conda_build_config.yaml
The conda build config was not changed but one or more of its dependencies have changed
Job Precheck on 8225b62 wanted to post the following:
A change of the following file(s) triggered this check:
conda/tools
The following file(s) are unchanged:
conda/mpich/conda_build_config.yaml
The conda build config was not changed but one or more of its dependencies have changed
Job Precheck on 341c9e9 wanted to post the following:
A change of the following file(s) triggered this check:
conda/tools
The following file(s) are unchanged:
conda/mpich/conda_build_config.yaml
The conda build config was not changed but one or more of its dependencies have changed
Job Precheck on 1a71aff wanted to post the following:
A change of the following file(s) triggered this check:
conda/tools
The following file(s) are unchanged:
conda/mpich/conda_build_config.yaml
The conda build config was not changed but one or more of its dependencies have changed
Abs zero has been re-implemented and there should be no barriers to merging.
It has not been reviewed so not yet. Any takers? EDIT: @loganharbour assigned himself so he's slated to take care of this
Job Precheck on 0402cd5 wanted to post the following:
A change of the following file(s) triggered this check:
conda/tools
The following file(s) are unchanged:
conda/mpich/conda_build_config.yaml
The conda build config was not changed but one or more of its dependencies have changed
Job Precheck on 5a4fe8f wanted to post the following:
A change of the following file(s) triggered this check:
conda/tools
The following file(s) are unchanged:
conda/mpich/conda_build_config.yaml
The conda build config was not changed but one or more of its dependencies have changed
Job Precheck on 728d7df wanted to post the following:
A change of the following file(s) triggered this check:
conda/tools
The following file(s) are unchanged:
conda/mpich/conda_build_config.yaml
The conda build config was not changed but one or more of its dependencies have changed
Job Precheck on c9c8008 wanted to post the following:
A change of the following file(s) triggered this check:
conda/tools
The following file(s) are unchanged:
conda/mpich/conda_build_config.yaml
The conda build config was not changed but one or more of its dependencies have changed
Job Precheck on a841052 wanted to post the following:
A change of the following file(s) triggered this check:
conda/tools
The following file(s) are unchanged:
conda/mpich/conda_build_config.yaml
The conda build config was not changed but one or more of its dependencies have changed