Kai Bao comments

Results 422 comments of


                                            Kai Bao

[testing] tightening tolerance wells to be 1.e-8

The benchmark looks very different from the previous ones. Will trigger again to confirm.

[testing] tightening tolerance wells to be 1.e-8

benchmark please

[testing] tightening tolerance wells to be 1.e-8

the benchmark appears not very stable. If needed, maybe we should test the cases on own machine to check the iteration numbers.

Fixed indexing error in PID controller

jenkins build this please

Fixed indexing error in PID controller

@erikhide, can you please rebase the branch on top of the master branch?

Fixed indexing error in PID controller

jenkins build this please

Fixed indexing error in PID controller

> are we having the awkward rebase conversation again? 😄 Let me know if we do not need it anymore. Just think "Merge OPM/master to master" does not look great,...

Fixed indexing error in PID controller

I will go through the regression failures and report back. From the discussion, it looks like a bug fix. But if you have more comments, please do so.

Fixed indexing error in PID controller

benchmark please

Fixed indexing error in PID controller

Let us get this in first and checking what happens with https://github.com/OPM/opm-simulators/pull/4856 .