Kai Bao comments

Results 422 comments of


                                            Kai Bao

When checking for zero target rates, also check wells under group control where required

Some how the regression related to `PYACTION_WCONPROD` does not look severe anymore. https://ci.opm-project.org/job/opm-simulators-PR-builder/6269/testReport/junit/(root)/mpi/compareECLFiles_flow_PYACTION_WCONPROD/ Then most likely, we do not need to adjust to make the regression test to work.

Changed the relative change used in adaptive time stepping

jenkins build this please

WIP: Enabling automatic choke to model a sub-sea manifold in an extended network

Thanks for the good result. I might leave some comments for discussion, not necessarily suggesting code change yet.

WIP: Enabling automatic choke to model a sub-sea manifold in an extended network

Thanks for the good work. It helps us to understand the auto-choke much better. Will come with concrete suggestion about the code.

WIP: Enabling automatic choke to model a sub-sea manifold in an extended network

jenkins build this please

WIP: Enabling automatic choke to model a sub-sea manifold in an extended network

jenkins build this please

WIP: Enabling automatic choke to model a sub-sea manifold in an extended network

Thanks for the update. I am looking into the function `computeWellGroupThp` now. Hopefully, we are close to get it in after that.

WIP: Enabling automatic choke to model a sub-sea manifold in an extended network

Hei, @plgbrts , I believe the tests you are testing is the case opm-tests/network/NETWORK_MODEL5_STDW_AUTOCHK.DATA in opm-tests. Can you add a regression test?

WIP: Enabling automatic choke to model a sub-sea manifold in an extended network

jenkins build this please

WIP: Enabling automatic choke to model a sub-sea manifold in an extended network

Sorry for the delay. I will test and check this PR today (some) and tomorrow.