Kai Bao comments

Results 422 comments of


                                            Kai Bao

[fix] reflect inactive cells due to MINPV/PINCH in Schedule::completed_cells

And all the failure messages are related to ``` flow: /var/lib/jenkins/workspace/opm-common-PR-builder/opm/input/eclipse/Schedule/Schedule.cpp:1327: void Opm::Schedule::filterConnections(const Opm::ActiveGridCells&): Assertion `cell.props' failed. ```

[fix] reflect inactive cells due to MINPV/PINCH in Schedule::completed_cells

Thanks. I will perform a test on the field case before reviewing the PR.

[fix] reflect inactive cells due to MINPV/PINCH in Schedule::completed_cells

I made a serial run and it did not look like it fixed the problem. I might made mistake, we should confirm that it did not fix first.

Go back to using fnmatch() instead of lots of regexes.

Can we rewrite the function without using regex and fnmatch() for both performance and portability issue?

Go back to using fnmatch() instead of lots of regexes.

> I suppose. That would effectively mean writing our own fnmatch() though. I think if the performance and portability both have priorities (especially if we do not need all the...

compositional

jenkins build this please

compositional

jenkins build this please

compositional

jenkins build this opm-models=901 opm-simulators=5382 please

compositional

jenkins build this opm-models=901 opm-simulators=5382 please

compositional

jenkins build this opm-models=901 opm-simulators=5382 please