OPM
[fix] reflect inactive cells due to MINPV/PINCH in Schedule::completed_cells
Previously only cells were marked as inactive that were inactive before MINPV/PINCH was applied and those inactive due to MINPV/PINCH might still have been active. This presented a problem whenever ACTIONX was run as this would recreate the schedule using the information in Schedule::completed_cells. We experienced problems because wells suddenly had completions in active cells.
With this commit we use filterConnections (called after MINPV/PINCH processing and creation of the grid in opm-simulators) to also mark cells in Schedule::completed_cells as inactive that became inactive due to MINPV/PINCH or small volumes.
many cases failed are related to aquifers,
mpi.compareECLFiles_flow+2D_FETKOVICHAQUIFER mpi.compareECLFiles_flow+AQUFLUX-02 mpi.compareECLFiles_flow+0_BASE_MODEL2 mpi.compareECLFiles_flow+0_BASE_MODEL2_LET mpi.compareECLFiles_flow+1_MULTREGT_MODEL2 mpi.compareECLFiles_flow+2_MULTXYZ_MODEL2 mpi.compareECLFiles_flow+3_MULTFLT_MODEL2 mpi.compareECLFiles_flow+4_MINPVV_MODEL2 mpi.compareECLFiles_flow+5_SWATINIT_MODEL2 mpi.compareECLFiles_flow+6_ENDSCALE_MODEL2 mpi.compareECLFiles_flow+7_HYSTERESIS_MODEL2 mpi.compareECLFiles_flow+8_MULTIPLY_TRANXYZ_MODEL2 mpi.compareECLFiles_flow+9_EDITNNC_MODEL2 mpi.compareRestartedSim_flow+2D_FETKOVICHAQUIFER mpi.compareRestartedSim_flow+AQUFLUX-02 mpi.compareParallelRestartedSim_flow+2D_FETKOVICHAQUIFER mpi.compareParallelRestartedSim_flow+AQUFLUX-02 mpi.compareParallelSim_flow+2D_FETKOVICHAQUIFER
And all the failure messages are related to
flow: /var/lib/jenkins/workspace/opm-common-PR-builder/opm/input/eclipse/Schedule/Schedule.cpp:1327: void Opm::Schedule::filterConnections(const Opm::ActiveGridCells&): Assertion `cell.props' failed.
I made a serial run and it did not look like it fixed the problem. I might made mistake, we should confirm that it did not fix first.