Giedrius Statkevičius

Updated the PR, I think it's ready to go: * Added back the series statistics that I had removed accidentally; * Added some unit tests for the deduplicating heap; *...

@fpetkovski that's a big drop :scream: previously we were doing _everything_ concurrently but with the eager version we wait for all of the results at first and then merge everything....

Updated PR: * Fixed everything according to comments; * Remove `Error()` method to not mislead readers - we actually convert all errors into warnings now and then the Series() function...

> Ha, the e2e test failure seems to be exactly what I saw :) Yeah 👍 trying to fix it and then we can merge this

I think I have fixed all of the bugs. PTAL @bwplotka @fpetkovski @yeya24 :pray:

Yeah, there's something wrong :( perhaps @yeya24 you know something about this? I had to disable vertical compaction for now due to this because it results in overhead for Thanos...

It's by design due to how deduplication works - in the beginning, we need to select one "true" series. Thanos uses a heuristic - it chooses the series with the...

Is it still reproducible if you disable deduplication? 🤔

Mhm, I see it now on my own Thanos cluster on some of the panels but it's still unclear to me what causes it or how to reproduce it consistently....

Could you please try reverting https://github.com/thanos-io/thanos/pull/5410 and see if it helps? I'll try looking into this once I'll have some time.