Ghostkeeper

Results 403 comments of Ghostkeeper

> I did include the old implementation only because i believe every change breaks someones work-flow, and i did try to avoid that. True. It's a concession we've needed to...

On point 8, honestly it's probably easier on yourself and on the code base if you drop that feature! It's not in the expected behaviour now, and while the result...

No, I expect that would work fine. Maybe choose carefully which operating system(s) you'll release on. I wonder how you'll know that your Cura version is being used, though? If...

I should also say that reviewing and testing 5000 lines of C++ code is no small task. Might take quite a while to get that in, especially considering there is...

[fdmprinter.def.json](https://github.com/Ultimaker/Cura/blob/master/resources/definitions/fdmprinter.def.json) is human-readable, right? All of these are required.

> This was a fun exercise, but I'd like to know if there is an interest in this before polishing it. I always like optimising that sort of stuff too...

> Thus, maybe the implementation should only perform strict merging, and then rely on the stitching of 2D polygons to close malformed paths. This would give another ~8x improvement in...

I couldn't get this result myself after trying for a bit via the CLI. I wonder how that can happen then though. This is the code that produces the error:...

Yup, this reproduces for me as well. I sliced a tall cylinder, set the infill density to 100% and the seam to back so that every layer but the first...

I would not implement this in the routine for skirt/brim. That will only have any effect on the first layer (and only if the skirt/brim is active). What is that...