Geert Custers

Results 45 comments of Geert Custers

We already do this for releases, unless you also suggest doing this for the master branch.

This PR currently has merge conflicts.

I think in general we should factor out the errno translation code, and just provide a general function that does the translation instead of open coding it in every sysdep.

How should ``ioctl`` in userspace check if the buffer is valid?

This PR needs a rebase, since it's currently missing the vinix sysdep compilation check. Shouldn't be any merge conflicts involved in that process though. I'm not sure what the consensus...

Are these implementations correct on all arches?

Okay then for now I'd be much more comfortable merging this with a proper static_assert to ensure that this is actually true. Silently breaking on an arch where this equivalence...

Yeah, that will suffice. That will break when porting to other arches, like x86 for example, where the struct layouts are different.