Eleni Lixourioti

Results 27 comments of Eleni Lixourioti

Looks like this is breaking `multi_select` tests now, I'll fix and update.

I think it's ready now. All feedback on this would be super-appreciated (especially since I'm not very well-versed in Ruby)! It should be easier to review this commit-by-commit, but they...

Thank you for the feedback @piotrmurach I'll look into making the suggested updates!

Hey @piotrmurach ! I have tried to address all the points above, again it may be easier to review per-commit 🙂

Hey @piotrmurach, I tried to tackle the points you raised, nitpicks are also fine, we can keep things tidy. Thanks again for the feedback.

No worries @piotrmurach, thanks for the update!

Hey @piotrmurach, just a quick ping on this for when you have a bit of time to have a look at the changes :)

@piotrmurach Woah, that sounds really rough! No time-stress about the PR, I only pinged in case it had fallen through the cracks. Even when everything is fine, it's still something...

Thank you for the feedback @piotrmurach ! I have made the smaller changes. Regarding Enum Select, I had a look at the implementation. Even though it's very similar to simple...

Hey @piotrmurach So I had a look at this `jruby-head` thing. I "fixed" it, but the actual cause was really weird. I've added it as a separate [commit](https://github.com/piotrmurach/tty-prompt/pull/163/commits/b4c71b62c954910a5435a5c273d4752a8e85fa69), if you...