Eleni Lixourioti

Results 27 comments of Eleni Lixourioti

@piotrmurach how does this sound? ``` Add custom key support to select and multi_select - Add :confirm_keys option to both `select` and `multi_select` - Add :select_keys option to `multi_select` -...

Hey @piotrmurach, I have added the DSL support, let me know what you think.

Hey @piotrmurach! I think I applied all the suggestions above. It's worth noting that in the case where the first parameter is a hash, the rounded brackets are still required...

Hi @piotrmurach, thanks for staying on top of this. I have pushed some more fixes for the things you raised.

@piotrmurach changes pushed, let's see – Nth-time lucky 😅

Hey @piotrmurach, I have addressed the last round of feedback. Let me know what you think!

Hey @piotrmurach ! Thanks for the instructions above, I'd never used yard before, I'll fix the warnings. How do you feel about adding these to the gemspec? ``` spec.add_development_dependency "yard"...

@piotrmurach I believe I have fixed all the list/multi_list warnings now.

Hey @piotrmurach, I'm not sure if we're running different versions of `yard` or something, but I'm not getting any of the `README.md` errors you are mentioning in the output, even...

Hey all! I stumbled upon the same problem, needing my filters to include spaces. I believe I have implemented what @piotrmurach described in the PR above, including the check for...