Gary Jones
Gary Jones
Feedback given by @rianrietveld in https://github.com/johnbillion/query-monitor/pull/285#issuecomment-346938513 indicated that when buttons are extracted from their context (such as screen reader software can do), then they are not uniquely identifiable. 
## Is your feature request related to a problem? (Follow-up to #2164) There may be some assumptions in WordPress core, standards packages for WP, or elsewhere, that PHP files used...
Original Issue: https://github.com/Automattic/VIP-Coding-Standards/issues/22 ---- ``` ``` reports issue with MY_CLASS and $vars, but should really only for MY_CLASS Another edge case: ``` ``` Another false positive is being reported on...
After refreshing https://github.com/GaryJones/pwa-wp/tree/phpcs-refresh, no violations are reported when running `phpcs`. All good. If I change: ```xml ``` to: ```xml ``` Then new violations are reported: ``` FILE: wp-includes/class-wp-service-workers.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND...
## What problem would the enhancement address for VIP? On VIP, a selection of [query parameters](https://docs.wpvip.com/technical-references/caching/page-cache/#h-query-parameters) are stripped at the edge which so that the URLs are not cached as...
## What problem would the enhancement address for VIP? Options get marked as autoload=yes when being added, unless there is an explicit setting to no. For VIP clients, we should...
## Bug Description The VIP Go standard uses `WordPress.Security.EscapeOutput.OutputNotEscaped` but doesn't recognize that the deprecated [`wpcom_vip_get_resized_remote_image_url()` function](https://github.com/Automattic/vip-go-mu-plugins/blob/dfc36174ce2274def920a9ed4bf88e7d50303b35/vip-helpers/vip-deprecated.php#L1130-L1139) auto-escapes if it's fourth argument is true (default). Since it's conditional, we can't...
## What problem would the enhancement address for VIP? When a file includes a load of other includes/requires, then part of the path might be assigned to a variable, to...
## What problem would the enhancement address for VIP? The frequency with which "Warning: File inclusion using custom constant (`PREFIX_PATH`). Probably needs manual inspection (WordPressVIPMinimum.Files.IncludingFile.UsingCustomConstant)." shows up just below a...
Things I'd like to see for this repo: - [x] Change log - [ ] Roadmap / proposed release schedule - [x] Milestones - [x] Useful labels that focus on...