Marco Ebert
Marco Ebert
I filed a PR for implementing the Ingress NGINX side of things: https://github.com/kubernetes/ingress-nginx/pull/13680.
> Hi @Gacko > > thanks for your review. Please take a look. I may ask if using gos sprintf `%q` has any downsides compared to `strconv.Quote` and `%v`. I...
I implemented the suggested changes, so we can still have this in the next patch release. As stated above, I removed the filtering for `\n` and `\r` since could potentially...
/cherry-pick release-1.13
/cherry-pick release-1.12
Please review your change, `CI / test-go` is failing for it.
Have you `git clean -xfd` your repository? Make sure there are no leftovers from `main` branch and update your local branch.
Adding a test is not about proving your change works, it's about ensuring it keeps working with future changes. So I'd ask you to add a test.
/triage accepted /kind documentation /priority backlog
Well, actually annotation validation was around in v1.11 already, just not enabled by default. So coming from v1.8.0, having it disabled would at least not change the behavior. I'm totally...