ingress-nginx icon indicating copy to clipboard operation
ingress-nginx copied to clipboard

Annotations: Allow `@` in URLs.

Open pando85 opened this issue 9 months ago • 13 comments

The same as #11739, we need to allow those kinds of configurations in case your group names contain your domain separated by an at symbol.

What this PR does / why we need it:

To allow group names that contain the domain.

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] CVE Report (Scanner found CVE and adding report)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I've read the CONTRIBUTION guide
  • [x] I have added unit and/or e2e tests to cover my changes.
  • [x] All new and existing tests passed.

pando85 avatar Jan 06 '25 10:01 pando85