GCHQ-Developer-741
GCHQ-Developer-741
Completed as part of a seperate check of the code examples
From the back of this, would be worth adding accessibility checks after the popover has been opened in the cypress tests. There currently aren't any and it would have caught...
No designs for this variant yet, or acceptance criteria, so is blocked until this is defined
Closed by https://github.com/mi6/ic-ui-kit/pull/2458
These issues and similar ones have been seen before. Some useful links for context around aria, ids and shadow-dom: - https://nolanlawson.com/2022/11/28/shadow-dom-and-accessibility-the-trouble-with-aria/ - https://caniuse.com/?search=ariaControlsElements Previous [PR](https://github.com/mi6/ic-ui-kit/pull/1644) for reference
Done in #1214
> the Personally I don't think so. The examples mentioned seem correct to me (using 993px for min-width would apply to anything >992px, and using 992px for max-width would apply...
https://github.com/mi6/ic-design-system/issues/1155
https://github.com/mi6/ic-design-system/issues/1156
Putting this back to ready for dev, as I've hit a bit of a wall with upgrading the `ukic/react` package. After updating the relevant packages mentioned above, I was able...