ic-ui-kit icon indicating copy to clipboard operation
ic-ui-kit copied to clipboard

fix(canary-web-components): updated breakpoint for data-table

Open GCHQ-Developer-741 opened this issue 1 year ago • 1 comments

Summary of the changes

Upped the breakpoint for ic-data-table column headers by 1px, to match our guidelines.

Related issue

#2352

Checklist

General

  • [x] Changes to docs package checked and committed.
  • [x] All acceptance criteria reviewed and met.

Testing

  • [x] Relevant unit tests and visual regression tests added.
  • [x] Visual testing against Figma component specification completed.
  • [x] Playground stories in React Storybook up to date, with any prop changes and additions addressed.
  • [x] Compare performance of modified components against develop using Performance addon in React Storybook.

Accessibility

  • [x] Accessibility Insights FastPass performed.
  • [x] A11y unit test added and yields no issues.
  • [x] A11y plug-in on Storybook yields no issues.
  • [x] Manual screen reader testing performed using NVDA and VoiceOver.
  • [x] Manual keyboard testing for keyboard controls and logical focus order.
  • [x] Correct roles used and ARIA attributes used correctly where required.
  • [x] Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.

Resize/zoom behaviour

  • [x] Page can be zoomed to 400% with no loss of content.
  • [x] Screen magnifier used with no issues.
  • [x] Text resized to 200% with no loss of content.
  • [x] Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.

System modes

  • [x] Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
  • [x] Windows High Contrast mode tested with no loss of content.
  • [x] System light and dark mode tested with no loss of content.
  • [x] Browser support tested (Chrome, Safari, Firefox and Edge).

Testing content extremes

  • [x] Min/max content examples tested with no loss of content or overflow.
  • [x] All prop combinations work without issue.
  • [x] Tested for FOUC (Flash of Unstyled Content) in both SSR (Server-Side Rendering) and SSG (Static Site Generation) settings.
  • [x] Controlled and uncontrolled input components tested.
  • [x] Props/slots can be updated after initial render.

GCHQ-Developer-741 avatar Oct 10 '24 12:10 GCHQ-Developer-741

View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/2352-data-table-breakpoint/web-components View your React branch deployment here: https://mi6.github.io/ic-ui-kit/branches/2352-data-table-breakpoint/react

github-actions[bot] avatar Oct 10 '24 12:10 github-actions[bot]

just a little comment that this makes us inconsistent with other places where we use 577px in the css, eg data-table-title-bar & side navigation. In other cases it uses 993px, which is 1 px above another of the thresholds). Do they need reviewing too?

ad9242 avatar Oct 14 '24 09:10 ad9242

the

Personally I don't think so. The examples mentioned seem correct to me (using 993px for min-width would apply to anything >992px, and using 992px for max-width would apply to anything <=992px) I believe this is intended behaviour as it covers our breakpoints correctly.

GCHQ-Developer-741 avatar Oct 14 '24 09:10 GCHQ-Developer-741