Jason Frey

@agrare I think the new PRs have broken a spec on master which verifies the count of BlacklistedEvent. See https://github.com/ManageIQ/manageiq/pull/23319#issuecomment-2619746500 ``` 1) BlacklistedEvent.seed re-seeds deleted event filters Failure/Error: expect(described_class.count).to eq(total_blacklist_entry_count...

As we discussed in PM, the service catalog items have the picture id, so you can get it indirectly by fetching the service catalog item. That being said, I could...

Not sure if we should de-normalize it, or make it a virtual_attribute. I was originally thinking denormalize it (in case the catalog item goes away), but then I think it...

@bdunne This is ready to go.

So, I think the problem is that the file path is part of the brakeman.ignore's fingerprint, and engines could live in different places 😭 - I think I have to...

@kbrock https://github.com/ManageIQ/manageiq/pull/23124/files#diff-62c4b53b7988735188b9b2ac5614a6f7a624451ebdd77f125d35dc6ee013b3d2R23 But also, the problem I'm having isn't that issue. The problem is that the issue exists in a plugin, and the [file path is part of the false-positive...

@jrafanie This should be ready for review now. I'm also going to cross-repo with ui-class to show that it works properly when run from within the engines. @miq-bot cross-repo-test manageiq-ui-classic

@jrafanie All of the rubocops are tripping on original brakeman code, so I am not going to change those.

Yeah I'm going to let it bake a bit - maybe backport in a week or 2 to see how the automated runs go and PRs go.

Backported to radjabov via merge of master into radjabov