manageiq icon indicating copy to clipboard operation
manageiq copied to clipboard
verified publisher icon ManageIQ

[WIP] Add appliance/container tests for ansible-runner

Open Fryguy opened this issue 6 months ago • 2 comments

This commit introduces Bats tests for ansible-runner to allow testing the manageiq-ansible-venv installation. This tests cover ansible-runner CLI tests as well as tests running through the Ansible::Runner Ruby class, even without database access.

This commit also includes changes to Ansible::Runner itself to allow for better detection of ansible and the manageiq-ansible-venv, allowing the tests to run on the old appliances with python3.9 as well as the new appliances with python3.12.

As such, this can (and should) be merged ahead of https://github.com/ManageIQ/manageiq-rpm_build/pull/573.

I've executed these test on containers before and after the RPM upgrade in https://github.com/ManageIQ/manageiq-rpm_build/pull/573 both with and without sourcing the manageiq-ansible-venv

Testing in containers you do the following:

dnf install bats
git clone https://github.com/bats-core/bats-support ~/.bats/libs/bats-support
git clone https://github.com/bats-core/bats-assert ~/.bats/libs/bats-assert

vmdb
source ./container_env
mkdir -p spec/lib

# Then outside of the container in the manageiq repo you do
# docker cp spec/lib/ansible <container_id>:/var/www/miq/vmdb/spec/lib

$ bats spec/lib/ansible/runner_execution_spec.bats
runner_execution_spec.bats
 ✓ [ansible-runner] runs a playbook
 ✓ [ansible-runner] runs a playbook with variables in a vars file
 ✓ [ansible-runner] runs a playbook with vault encrypted variables
 ✓ [ansible-runner] runs a playbook with variables in a vault encrypted vars file
 ✓ [ansible-runner] runs a playbook using roles from github
 ✓ [ansible-runner] runs a role
 ✓ [ansible-runner] vmware collection
 ✓ [ansible-runner] aws collection
 ✓ [Ansible::Runner] runs a playbook
 ✓ [Ansible::Runner] runs a playbook with variables in a vars file
 - [Ansible::Runner] runs a playbook with vault encrypted variables (skipped: requires database access)
 - [Ansible::Runner] runs a playbook with variables in a vault encrypted vars file (skipped: requires database access)
 ✓ [Ansible::Runner] runs a playbook using roles from github
 ✓ [Ansible::Runner] runs a role
 ✓ [Ansible::Runner] vmware collection
 ✓ [Ansible::Runner] aws collection

16 tests, 0 failures, 2 skipped

WIP TODO:

  • [ ] Update the Ruby tests for python 3.12 and the newer manageiq-ansible-venv changes in https://github.com/ManageIQ/manageiq-rpm_build/pull/573
  • [ ] Test again on appliances in all configurations (before and after the RPM upgrade in https://github.com/ManageIQ/manageiq-rpm_build/pull/573 both with and without sourcing the manageiq-ansible-venv)
  • [ ] Add the new aws and vmware tests to the rspec tests.
  • [ ] Add tests for all of the other collections (I might do this in a followup)

Fryguy avatar Jun 13 '25 22:06 Fryguy

@bdunne This is ready to go.

Fryguy avatar Jun 16 '25 22:06 Fryguy

Checked commit https://github.com/Fryguy/manageiq/commit/707b594190f30457234e183f96d3a9f76ef991d7 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.62.0, and yamllint 5 files checked, 1 offense detected

**

  • [ ] :bomb: :boom: :fire: :fire_engine: - Linter/Rubocop - Linter::Rubocop STDERR:
`EnsureNode#body` is deprecated and will be changed in the next major version of rubocop-ast. Use `EnsureNode#branch` instead to get the body of the `ensure` branch.
Called from:
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/style/redundant_assignment.rb:88:in `check_ensure_node'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/style/redundant_assignment.rb:65:in `check_branch'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/style/redundant_assignment.rb:100:in `check_begin_node'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/style/redundant_assignment.rb:67:in `check_branch'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/style/redundant_assignment.rb:100:in `check_begin_node'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/style/redundant_assignment.rb:67:in `check_branch'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/style/redundant_assignment.rb:51:in `on_def'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:107:in `public_send'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:107:in `block (2 levels) in trigger_responding_cops'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:171:in `with_cop_error_handling'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:106:in `block in trigger_responding_cops'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:105:in `each'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:105:in `trigger_responding_cops'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:69:in `on_def'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `block in on_dstr'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `each'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `on_dstr'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:71:in `on_begin'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:147:in `on_while'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:71:in `on_sclass'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:163:in `on_class'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:71:in `on_class'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:147:in `on_while'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:71:in `on_module'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:20:in `walk'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:87:in `investigate'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/team.rb:156:in `investigate_partial'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/team.rb:98:in `investigate'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:345:in `block in inspect_file'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:344:in `each'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:344:in `flat_map'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:344:in `inspect_file'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:287:in `block in do_inspection_loop'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:321:in `block in iterate_until_no_changes'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:314:in `loop'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:314:in `iterate_until_no_changes'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:283:in `do_inspection_loop'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:164:in `block in file_offenses'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:189:in `file_offense_cache'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:163:in `file_offenses'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:154:in `process_file'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:135:in `block in each_inspected_file'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:134:in `each'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:134:in `reduce'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:134:in `each_inspected_file'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:120:in `inspect_files'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:73:in `run'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli/command/execute_runner.rb:26:in `block in execute_runner'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli/command/execute_runner.rb:52:in `with_redirect'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli/command/execute_runner.rb:25:in `execute_runner'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli/command/execute_runner.rb:17:in `run'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli/command.rb:11:in `run'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli/environment.rb:18:in `run'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli.rb:118:in `run_command'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli.rb:125:in `execute_runners'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli.rb:51:in `block in run'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli.rb:77:in `profile_if_needed'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli.rb:43:in `run'
/usr/share/gems/gems/rubocop-1.56.3/exe/rubocop:19:in `block in <top (required)>'
/usr/share/ruby/benchmark.rb:311:in `realtime'
/usr/share/gems/gems/rubocop-1.56.3/exe/rubocop:19:in `<top (required)>'
/usr/bin/rubocop:25:in `load'
/usr/bin/rubocop:25:in `<main>'

`EnsureNode#body` is deprecated and will be changed in the next major version of rubocop-ast. Use `EnsureNode#branch` instead to get the body of the `ensure` branch.
Called from:
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/layout/indentation_width.rb:67:in `on_ensure'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:107:in `public_send'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:107:in `block (2 levels) in trigger_responding_cops'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:171:in `with_cop_error_handling'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:106:in `block in trigger_responding_cops'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:105:in `each'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:105:in `trigger_responding_cops'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:69:in `on_ensure'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `block in on_dstr'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `each'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `on_dstr'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:71:in `on_kwbegin'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `block in on_dstr'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `each'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `on_dstr'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:71:in `on_begin'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:163:in `on_def'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:71:in `on_def'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `block in on_dstr'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `each'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `on_dstr'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:71:in `on_begin'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:147:in `on_while'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:71:in `on_sclass'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:163:in `on_class'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:71:in `on_class'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:147:in `on_while'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:71:in `on_module'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:20:in `walk'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:87:in `investigate'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/team.rb:156:in `investigate_partial'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/team.rb:98:in `investigate'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:345:in `block in inspect_file'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:344:in `each'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:344:in `flat_map'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:344:in `inspect_file'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:287:in `block in do_inspection_loop'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:321:in `block in iterate_until_no_changes'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:314:in `loop'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:314:in `iterate_until_no_changes'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:283:in `do_inspection_loop'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:164:in `block in file_offenses'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:189:in `file_offense_cache'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:163:in `file_offenses'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:154:in `process_file'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:135:in `block in each_inspected_file'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:134:in `each'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:134:in `reduce'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:134:in `each_inspected_file'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:120:in `inspect_files'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:73:in `run'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli/command/execute_runner.rb:26:in `block in execute_runner'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli/command/execute_runner.rb:52:in `with_redirect'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli/command/execute_runner.rb:25:in `execute_runner'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli/command/execute_runner.rb:17:in `run'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli/command.rb:11:in `run'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli/environment.rb:18:in `run'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli.rb:118:in `run_command'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli.rb:125:in `execute_runners'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli.rb:51:in `block in run'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli.rb:77:in `profile_if_needed'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli.rb:43:in `run'
/usr/share/gems/gems/rubocop-1.56.3/exe/rubocop:19:in `block in <top (required)>'
/usr/share/ruby/benchmark.rb:311:in `realtime'
/usr/share/gems/gems/rubocop-1.56.3/exe/rubocop:19:in `<top (required)>'
/usr/bin/rubocop:25:in `load'
/usr/bin/rubocop:25:in `<main>'

`EnsureNode#body` is deprecated and will be changed in the next major version of rubocop-ast. Use `EnsureNode#branch` instead to get the body of the `ensure` branch.
Called from:
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/lint/empty_ensure.rb:51:in `on_ensure'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:107:in `public_send'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:107:in `block (2 levels) in trigger_responding_cops'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:171:in `with_cop_error_handling'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:106:in `block in trigger_responding_cops'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:105:in `each'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:105:in `trigger_responding_cops'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:69:in `on_ensure'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `block in on_dstr'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `each'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `on_dstr'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:71:in `on_kwbegin'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `block in on_dstr'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `each'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `on_dstr'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:71:in `on_begin'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:163:in `on_def'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:71:in `on_def'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `block in on_dstr'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `each'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `on_dstr'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:71:in `on_begin'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:147:in `on_while'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:71:in `on_sclass'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:163:in `on_class'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:71:in `on_class'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:147:in `on_while'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:71:in `on_module'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:20:in `walk'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:87:in `investigate'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/team.rb:156:in `investigate_partial'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/team.rb:98:in `investigate'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:345:in `block in inspect_file'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:344:in `each'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:344:in `flat_map'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:344:in `inspect_file'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:287:in `block in do_inspection_loop'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:321:in `block in iterate_until_no_changes'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:314:in `loop'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:314:in `iterate_until_no_changes'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:283:in `do_inspection_loop'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:164:in `block in file_offenses'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:189:in `file_offense_cache'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:163:in `file_offenses'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:154:in `process_file'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:135:in `block in each_inspected_file'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:134:in `each'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:134:in `reduce'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:134:in `each_inspected_file'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:120:in `inspect_files'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:73:in `run'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli/command/execute_runner.rb:26:in `block in execute_runner'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli/command/execute_runner.rb:52:in `with_redirect'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli/command/execute_runner.rb:25:in `execute_runner'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli/command/execute_runner.rb:17:in `run'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli/command.rb:11:in `run'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli/environment.rb:18:in `run'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli.rb:118:in `run_command'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli.rb:125:in `execute_runners'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli.rb:51:in `block in run'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli.rb:77:in `profile_if_needed'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli.rb:43:in `run'
/usr/share/gems/gems/rubocop-1.56.3/exe/rubocop:19:in `block in <top (required)>'
/usr/share/ruby/benchmark.rb:311:in `realtime'
/usr/share/gems/gems/rubocop-1.56.3/exe/rubocop:19:in `<top (required)>'
/usr/bin/rubocop:25:in `load'
/usr/bin/rubocop:25:in `<main>'

`EnsureNode#body` is deprecated and will be changed in the next major version of rubocop-ast. Use `EnsureNode#branch` instead to get the body of the `ensure` branch.
Called from:
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/lint/ensure_return.rb:54:in `on_ensure'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:107:in `public_send'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:107:in `block (2 levels) in trigger_responding_cops'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:171:in `with_cop_error_handling'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:106:in `block in trigger_responding_cops'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:105:in `each'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:105:in `trigger_responding_cops'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:69:in `on_ensure'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `block in on_dstr'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `each'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `on_dstr'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:71:in `on_kwbegin'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `block in on_dstr'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `each'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `on_dstr'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:71:in `on_begin'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:163:in `on_def'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:71:in `on_def'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `block in on_dstr'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `each'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:146:in `on_dstr'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:71:in `on_begin'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:147:in `on_while'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:71:in `on_sclass'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:163:in `on_class'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:71:in `on_class'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:147:in `on_while'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:71:in `on_module'
/usr/share/gems/gems/rubocop-ast-1.44.0/lib/rubocop/ast/traversal.rb:20:in `walk'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/commissioner.rb:87:in `investigate'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/team.rb:156:in `investigate_partial'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cop/team.rb:98:in `investigate'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:345:in `block in inspect_file'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:344:in `each'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:344:in `flat_map'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:344:in `inspect_file'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:287:in `block in do_inspection_loop'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:321:in `block in iterate_until_no_changes'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:314:in `loop'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:314:in `iterate_until_no_changes'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:283:in `do_inspection_loop'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:164:in `block in file_offenses'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:189:in `file_offense_cache'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:163:in `file_offenses'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:154:in `process_file'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:135:in `block in each_inspected_file'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:134:in `each'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:134:in `reduce'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:134:in `each_inspected_file'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:120:in `inspect_files'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/runner.rb:73:in `run'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli/command/execute_runner.rb:26:in `block in execute_runner'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli/command/execute_runner.rb:52:in `with_redirect'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli/command/execute_runner.rb:25:in `execute_runner'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli/command/execute_runner.rb:17:in `run'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli/command.rb:11:in `run'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli/environment.rb:18:in `run'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli.rb:118:in `run_command'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli.rb:125:in `execute_runners'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli.rb:51:in `block in run'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli.rb:77:in `profile_if_needed'
/usr/share/gems/gems/rubocop-1.56.3/lib/rubocop/cli.rb:43:in `run'
/usr/share/gems/gems/rubocop-1.56.3/exe/rubocop:19:in `block in <top (required)>'
/usr/share/ruby/benchmark.rb:311:in `realtime'
/usr/share/gems/gems/rubocop-1.56.3/exe/rubocop:19:in `<top (required)>'
/usr/bin/rubocop:25:in `load'
/usr/bin/rubocop:25:in `<main>'

miq-bot avatar Jun 17 '25 17:06 miq-bot

Some comments on commit https://github.com/Fryguy/manageiq/commit/707b594190f30457234e183f96d3a9f76ef991d7

lib/tasks/test_security_helper.rb

  • [ ] :warning: - 26 - Detected puts. Remove all debugging statements.

spec/lib/ansible/runner_execution_spec.bats

  • [ ] :warning: - 135 - Detected puts. Remove all debugging statements.
  • [ ] :warning: - 139 - Detected puts. Remove all debugging statements.

miq-bot avatar Jun 17 '25 17:06 miq-bot