Jason Frey
Jason Frey
The only thing I can think of that I didn't see covered in any of the comments here (unless I missed it), is that we have a handful of virtual...
Nope I love it
I also commented here (https://github.com/ManageIQ/manageiq/pull/22989#issuecomment-2052639385) with similar findings as you. I agree we can drop `tag_expr`.
@jeffibm Can you take a look at this one? I think it might be realted to the services screen rewrite to react.
I don't think this is a clean refactoring, particularly if both guid and system-uid are passed (not sure that's possible). Even so, the first conditional is `find_by!(:guid)` (note the `!`)...
@kbrock Can you rename the PR title to be more descriptive of the change?
> @Fryguy Is this related to our previous discussion around removing edit from some request models in the api? I don't believe so
Is this the same issue as https://github.com/ManageIQ/manageiq/issues/22847 ?
Yeah these both sound like bugs. For 1. that is likely a presentation issue and I agree that when DHCP is chosen the other fields should be disabled. For 2,...
@GilbertCherrie Can you take a look at the UI issue on this one? @agrare Can you take a look at the underlying provisioning issue? (It might still be UI, not...