Jason Frey
Jason Frey
hi @mattyr - bump?
Honestly I don't remember - this was a cross-repo thing, but I'm not sure it's needed?
Ok thanks - I double checked and Ruby _is_ installed by default in GHA, so this could be a ruby script: See https://github.com/Fryguy/sandbox/actions/runs/5178658485/jobs/9330435149#step:10:18 (installed version is `ruby 3.0.2p107 (2021-07-07 revision...
I thought setup_gemfile_lock was also called in core bin/setup, so specs would use it. But I don't see that here. 🤔
We were just waiting on a rewrite to Ruby. We can merge now with python and change in a follow up. Separately we need a change to all of the...
I was about to merge but noticed the python script doesn't modify the Gemfile.lock.release, but instead modifies Gemfile.lock. Not sure I understand how that's supposed to work?
@agrare ok that part makes sense, but the "copy Gemfile.lock.release to Gemfile.lock" line was removed here https://github.com/ManageIQ/manageiq/pull/22075/files#diff-3407d3d6c1f5822da11eac8ba10639efe824e11d65c8bd19ce034253ea124eb9L85. Or is this relying on the core bin/before_install (https://github.com/ManageIQ/manageiq/blob/34f0a74a240d3b92ecf115d3346725469efc0f46/bin/before_install#L40-L45) somehow in the plugin...
Cluster has a normal vms relationship in the database...this is the same as "all_vms". direct_vms goes through resource_pools which is relationship based and only gets vms directly in the immediate...
I totally forgot I forked it with that fix 😆
That's why I said "if a) the project points to an org". For example, ManageIQ's entry points to the org, not a specific repo: https://github.com/RedHatOfficial/RedHatOfficial.github.io/blob/7fec81a61de91d92c0bb36c7cc2a4f69c9315655/app/data/projects.json#L1681