Tom Dohrmann

Results 150 comments of Tom Dohrmann

Can you elaborate on what specific files you want to write to? > Can it replace some Assembly I don't think we'll want to replace assembly with straight-up machine code....

We already make bootable BIOS and UEFI images.

On Linux, stdin is not always the controlling terminal and it's not even necessarily a tty. The prime example is piped commands (think `cat foo.txt | sort`) where stdin is...

Thank you for your contribution! I'm not sure if we want to implement these traits because I think the lack of implementations for those is intentional. The idea behind `InterruptStackFrame`...

> I don't see how that would be possible. The inner value is still private so it can't be changed. Also it is currently not possible to construct the wrapper...

> I don't agree. &mut InterruptStackFrame does nothing as InteruptStackFrame has no functions that allow for modification so I don't understand why I would use that. > [...] > `InterruptStackFrame`...

> I don't really understand why your above example doesn't work with the interrupt ABI but I am willing to take your word for it. Here's another angle to look...

`flags` doesn't contain `PageTableFlags::PRESENT`, and that's why it's failing. Adding that flag makes it work.

> * How the Physical Address stuff interacts with the memory encryption bit. If the C-bit isn't bit 52 (it's usually bit 47), could a valid physical address underflow into...

Thanks for the detailed write-up! I think we should require the `PRESENT` flag in `translate`. The documentation for [`translate`](https://docs.rs/x86_64/latest/x86_64/structures/paging/mapper/trait.Translate.html#tymethod.translate) says: > Return the frame that the given virtual address is...