Tom Dohrmann
Tom Dohrmann
Sure, sounds good to me!
Why was this PR closed? Couldn't we just have switched the target branch to `main`?
Thanks!
> @Freax13 I think the function I added with this pull request is a bit redundant now that I see the const_fn feature in the crate, Yeah, you're right. I'm...
> Any thoughts on what the name of this function should be? `limit` seems reasonable to me. Can you move the function down (before or after `pointer`) and also change...
Heyyyyy
Related to #74
This only occurs when using rsdp `2.0.0` and seems to be fixed by rsdp `2.0.1`. I've tracked the fix down to this commit: https://github.com/rust-osdev/acpi/commit/a0db984096d49a499117760f913ea86ce5e9b604, but I'm not entirely sure why...
I can still reproduce this on `1.78.0-nightly` (tested with 090f0309fb41c2ff19b1a79b5567cecc3ca084df).
Can you elaborate on why the compiler would be allowed to optimize out the non-volatile read?