Tom Dohrmann
Tom Dohrmann
I don't think we should change the behavior of existing methods in such a drastic way. There might be people that depend on the current behavior.
I'm open to that idea (although I don't like that method name). Another idea might be to improve `TranslateResult` to also contain the page table flags for the upper levels....
Sure. We'd have to make sure that the CPU supports it (CPUID leaf 8000_0001, EDX, Page1GB). Feel free to open a PR.
> [...] especially since the function doesn't even document that it does this. This behavior is documented: https://github.com/rust-osdev/x86_64/blob/f01a291ecb0c1c8e8a5f5d58c29fbd9588a1486c/src/structures/idt.rs#L813 > Imo the IDT Rust wrapper should have consistent behavior and its...
Using the current CS value is a reasonable default. We also provide defaults for other fields. I don't think replacing all these defaults with explicit arguments in `set_handler_addr` is worth...
Can we close this?
bootimage builds images compatible with the bootloader crate (Version 0.9). It does not do anything related to multiboot2.
Hmm, there's not much to go on. How did you track this hang down to this line? Can you share the log output?
The frame buffer (0xfc_1000_0000) address is in the second pml4 entry, interesting. Currently, we only copy the first pml4 entry, but when the bootloader tries to access the frame buffer...
> As discussed, I believe the full requirements are: > > * All variants must be themselves NoUninit > > * All variants must be the same size > >...