Franz Heinzmann
Franz Heinzmann
Needs rebase
Rebased this. Needs a quic-rpc release first though.
Rebased again and bumped quic-rpc. Should be good to go now. Edit: quic-rpc has MSRV 1.76, so bumped ours from 1.75 to 1.76 as well.
The failure is here: https://github.com/n0-computer/iroh/blob/main/iroh/src/node.rs#L658 ```rust let hash = node1.blobs().add_bytes(b"foo".to_vec()).await?.hash; // create a node addr with node id only let addr = NodeAddr::new(node1.node_id()); node2.blobs().download(hash, addr).await?.await?; ``` I don't see a...
Yes, I'm also not too sure anymore. I thought initially that this could be done without opening any streams, which would put it more into endpoint-layer land. Alas, an extra...
Closing this PR for now. We'll iterate in userland, and maybe create an `iroh-util` crate post-1.0. FWIW iroh-blobs now also contains a different version of a connection pool: https://github.com/n0-computer/iroh-blobs/blob/main/src/util/connection_pool.rs
Hi @azzamsa, thank you for the detailed report, I can replicate the issue and am now digging in.
Hi, I found the cause of your issue. You have to make sure to *always* call `node.shutdown().await` before exiting the process, otherwise pending write transactions in the blobs or docs...
> @Frando what do you think about printing a warning in Node, when it's dropped, if it hasn't been shutdown yet? Yes. In the team chat we agreed the current...
The fix was incorrect, pushed two commits: * we need to join gossip also if no peers are set. * we may not skip node addrs that have empty address...