iroh icon indicating copy to clipboard operation
iroh copied to clipboard

Published 20 hours ago • verified publisher icon n0-computer

refactor: quic-rpc simpler generics

Open Frando opened this issue 9 months ago • 1 comments

Description

Adapts iroh for n0-computer/quic-rpc#76 Based on #2263

Wit this change, a quic client is pub type QuicIroh = Iroh<QuinnConnection<RpcService>> instead of pub type QuicIroh = Iroh<QuinnConnection<ProviderRequest, ProviderResponse>>

Breaking Changes

  • The generics of the iroh clients changed: Instead of taking ProviderRequest, ProviderResponse as generics, they now take RpcService

Notes & open questions

Change checklist

  • [ ] Self-review.
  • [ ] Documentation updates if relevant.
  • [ ] Tests if relevant.
  • [ ] All breaking changes documented.

Frando avatar May 06 '24 12:05 Frando

Needs rebase

Frando avatar May 07 '24 15:05 Frando

Rebased this. Needs a quic-rpc release first though.

Frando avatar May 21 '24 08:05 Frando

release is done

dignifiedquire avatar May 22 '24 10:05 dignifiedquire

Rebased again and bumped quic-rpc. Should be good to go now.

Edit: quic-rpc has MSRV 1.76, so bumped ours from 1.75 to 1.76 as well.

Frando avatar May 22 '24 23:05 Frando

working on deps updates here: https://github.com/n0-computer/quic-rpc/pull/80

dignifiedquire avatar May 24 '24 10:05 dignifiedquire