EmbeddedController

EmbeddedController copied to clipboard

hx20: restore RW firmware access

8

This pull request comprises three bug fixes. ### 1. lfw: restore RW firmware access by using the right pin mux The alternate function table for LFW on the hx20 contained...

DHowett

Possibly use a "baseboard" to unify hx20 and hx30

1

Depending on how similar the hx* boards are, it may be possible--and perhaps advantageous!--to unify their implementations as a baseboard (see the `baseboard` directory for other examples.) That would make...

DHowett

docs: Fix a few typos

2

There are small typos in: - baseboard/kukui/charger_mt6370.c - board/hatch/board.c - board/stryke/board.c - chip/npcx/system-npcx5.c - chip/npcx/system-npcx7.c - driver/bc12/pi3usb9201.c - driver/charger/rt946x.h Fixes: - Should read `jumping` rather than `jumpiing`. - Should read...

timgates42

The MEC LPC protocol is supported in Linux' `cros_ec_lpcs` driver, but not in ectool's "local" implementation. However, `cros_ec_lpcs` will not load on the Framework Laptop due to an I/O port...

DHowett

Do not reset charge_max_level during CHG_LIMIT_GET_LIMIT

3

Reading into `charging_maximum_level` overwrites `CHG_LIMIT_OVERRIDE`; `GET_LIMIT` should not change global state. Fixes #6.

DHowett

hx20: CHARGE_LIMIT_CONTROL min_percentage is unused

1

Filing this as a feature request! It looks like you planned on having a configurable min percentage for the charge limit, presumably to allow the battery to fall to a...

DHowett

Querying the charge limit with host command `CHARGE_LIMIT_CONTROL` mode `CHG_LIMIT_GET_LIMIT` reloads the charge limit from bbram, which overwrites the `CHG_LIMIT_OVERRIDE` flag. Flag is set here (and not stored to bbram,...

DHowett

hx20: FP_LED_LEVEL_CONTROL takes symbolic inputs but returns raw outputs

1

Calling the `FP_LED_LEVEL_CONTROL` host command with `set` requires one of the symbolic LED brightnesses: * `FP_LED_BRIGHTNESS_HIGH` = `0` * `FP_LED_BRIGHTNESS_MEDIUM` = `1` * `FP_LED_BRIGHTNESS_LOW` = `2` However, calling it with...

DHowett

Add ectool support for framework laptop

3

Without this patch: ``` EmbeddedController $ make utils VERSION ec_version.h HOSTCC util/ectool HOSTCC util/lbplay HOSTCC util/stm32mon HOSTCC util/ec_sb_firmware_update HOSTCC util/lbcc HOSTCC util/ec_parse_panicinfo HOSTCC util/cbi-util HOSTCC util/uartupdatetool EmbeddedController $ sudo ./build/bds/util/ectool...

razzius

add 'Off' setting for power LED

3

resolves #11 upfront warning - I have no experience in firmware, and haven't worked with C in around a decade (or ever in a professional context). I haven't yet loaded...

hauntingEcho