add 'Off' setting for power LED

Open hauntingEcho opened this issue 3 years ago • 3 comments

resolves #11

upfront warning - I have no experience in firmware, and haven't worked with C in around a decade (or ever in a professional context). I haven't yet loaded this onto my own laptop to test as it's my daily-driver. Skepticism / thorough review is warranted :)

breath length is left alone, since it's breathing from 0 to 0. Disabling breath may be better for battery life?

Mar 07 '22 05:03 hauntingEcho

Looks like it would work

May 26 '23 08:05 PeterHindes

Any plans on this getting merged any time ?

Nov 28 '23 20:11 AkechiShiro

I just tested, it seems, we can turn off the power LED under kernel 6.11 without this PR, see : https://github.com/FrameworkComputer/EmbeddedController/issues/11#issuecomment-2426980058

Oct 22 '24 06:10 AkechiShiro