fdb-record-layer

fdb-record-layer copied to clipboard

Rename methods that change an index's state to indicate they are async

1

There a few methods that manipulate an index's state, and those are currently asynchronous as they can perform database reads (though, arguably, they should read those from memory and just...

alecgrieser

As part of the plan cache effort, adding a query hash kind that takes into account literals and ignores parameter markers. The idea is that plans can be cached for...

ohadzeliger

In an unrelated PR (#270), the `ExtendedDirectoryLayerTest::testSetMappingWithConflicts` failed with the following error: ``` 12:13:20 com.apple.foundationdb.record.provider.foundationdb.keyspace.ExtendedDirectoryLayerTest > testSetMappingWithConflicts() FAILED 12:13:20 org.opentest4j.AssertionFailedError: nothing was added for the wrong value ==> Expected java.util.concurrent.CompletionException...

alecgrieser

Mismatched boundary keys in FDBRecordStoreIndexTest::boundaryPrimaryKeys

1

At least one PR unrelated to the boundary keys work has failed to due an error in this function. The error encountered was: ``` com.apple.foundationdb.record.provider.foundationdb.FDBRecordStoreIndexTest > boundaryPrimaryKeys() FAILED org.opentest4j.AssertionFailedError: expected:...

alecgrieser

testOrQuery5WithLimits intermittently fails with a NoSuchElementException

3

The `testOrQuery5WithLimits` test has intermittently failed with `NoSuchElementException` trying to pop from the queue: ``` 10:36:59 com.apple.foundationdb.record.provider.foundationdb.query.FDBOrQueryToUnionTest > testOrQuery5WithLimits(int)[1] FAILED 10:36:59 java.util.NoSuchElementException 10:36:59 at java.util.ArrayDeque.removeFirst(ArrayDeque.java:285) 10:36:59 at java.util.ArrayDeque.remove(ArrayDeque.java:452) 10:36:59 at...

alecgrieser

There was an attempt to fix it but closed: https://github.com/FoundationDB/fdb-record-layer/pull/466

nblintao

We currently use hamcrest matchers to assert on the plan structure in our test cases. That can be problematic for downstream environments that cannot or do not want to use...

normen662

Move nested classes out of Comparisons class

1

Currently, most `Comparison` implementations are nested inside of the `Comparisons` class, which is effectively used as a namespace. This has gotten a bit unwieldy. Although it's a large breaking change,...

nschiefer

Deprecate in-memory recordsScanned counter for "Built Range" logs

9

Today, `OnlineIndexer` uses an in-memory counter `recordsScanned` to log how many records have been scanned ("Built Range" logs) once every 5 minutes, while it uses a value persisted in `scannedRecordsSubspace`...

nblintao

The primary key turns into a stored field, but as a byte array. Also, if the primary key has multiple components there is still only one field in the document....

MMcM