Deprecate in-memory recordsScanned counter for "Built Range" logs

[nblintao]

Today, OnlineIndexer uses an in-memory counter recordsScanned to log how many records have been scanned ("Built Range" logs) once every 5 minutes, while it uses a value persisted in scannedRecordsSubspace for IndexBuildState requests.

We should deprecate recordsScanned and just use scannedRecordsSubspace in "Built Range" logs. And we can also add recordsInTotal to that log. In fact, all fields of IndexBuildState could be there.

[vasantteja]

Can you please assign this to me?

[nblintao]

@vasantteja Of course. Thanks for being interested! Please let me you if you have any question.

[nblintao]

Hi @vasantteja, any progress? Do you need any help?

[vasantteja]

Should I create another branch or should I fork this and make the changes on those?

[vasantteja]

@nblintao can you please let me know how you want me to proceed?

[nblintao]

@vasantteja Sorry I missed your earlier message. You should:

1. fork this repository as your own repository
2. create a new branch on your own repository to develop
3. After you finish, create a Pull Request to the main branch of this repository from the feature branch of your own repository.

And this will be helpful as well. https://github.com/FoundationDB/fdb-record-layer/blob/main/CONTRIBUTING.md#opening-a-pull-request

[nblintao]

@vasantteja For the general workflow of making a pull request, I find this might be helpful https://github.com/firstcontributions/first-contributions

[nblintao]

Hi @vasantteja, do you still intend to work on this issue?

[vasantteja]

@nblintao hey yeah. I intend to work on this.