Forgind

Results 200 comments of Forgind

I looked at [documentation for ZipArchive](https://docs.microsoft.com/dotnet/api/system.io.compression.ziparchiveentry.name?view=net-6.0). It explicitly states that it looks after the last path separator character (\\). I'm guessing it hasn't been made unix-friendly and doesn't realize that...

We changed to using BuildWithNetFrameworkHostedCompiler instead of UseRoslynSdk. PR is here: https://github.com/dotnet/sdk/pull/29787 So yes! We now support that. I also have a PR out to backport it to 7.0.3xx; we'll...

From what I currently understand, the solution metaproject information is not properly transferred between nodes and possibly cannot be transferred between nodes. @mattaquinn commented in https://github.com/dotnet/msbuild/issues/8184#issuecomment-1339629311 that adding MSBUILDEMITSOLUTION=1 resolved...

I don't think we should have to worry about parallel MSBuild invocations, as this is for building .sln files—the sln itself isn't mutlitargeted, and if you try to build it...

Hmm...that is an excellent point. MSBuild looks for quite a few things right next to it and uses relative paths for more, so moving it to another directory would be...

jeffkl and I investigated this yesterday in the SDK insertion PR and found the same root cause as YuliiaKovalova. We also decided it's probably best to just update the tests....

You're correct that I didn't take into account DOTNET_ROOT when I made that PR. I made a follow-up [here](https://github.com/microsoft/MSBuildLocator/pull/225) that should resolve that issue. Thanks for diagnosing this!

> > A new error is showing up from the Aspire test. This isn't specific to my changes. I can repro it using the latest built SDK from the unified...

Can you use the [Copy](https://docs.microsoft.com/en-us/visualstudio/msbuild/copy-task?view=vs-2019) task to move them right after they're generated?

I think this is low enough priority that it doesn't warrant a serious design discussion. I'd personally prefer to just take this roughly as-is over closing it, but closing it...