MSBuildLocator icon indicating copy to clipboard operation
MSBuildLocator copied to clipboard

Indicates whether Roslyn is included

Open Forgind opened this issue 5 years ago • 1 comments

Fixes #22

I didn't see an obvious way to determine whether the C# compiler was installed for the dotnet sdk, and I didn't want to replicate all the logic from VSLocationHelper for a command prompt. Maybe right?

Forgind avatar Dec 10 '20 19:12 Forgind

I could expose instance as a parameter as I have ContainsRoslynCompiler exposed here. Would you want the non-VS versions to return null for that?

Forgind avatar Dec 10 '20 20:12 Forgind

Hi @rainersigwald and @Forgind,

Do we plan to work on this PR? Can we close it?

YuliiaKovalova avatar Jun 14 '23 07:06 YuliiaKovalova

I think we need to have a design for #22 before taking any implementation and would favor closing this.

rainersigwald avatar Jun 14 '23 15:06 rainersigwald

I think this is low enough priority that it doesn't warrant a serious design discussion. I'd personally prefer to just take this roughly as-is over closing it, but closing it makes more sense than talking about it for too long.

Forgind avatar Jun 14 '23 18:06 Forgind