Alexander Grund

remove code that was required to support Python 2.6

5

As Python

allow tweaking of easyconfigs from different toolchains

2

This is useful to bulk-install e.g. Python with enable_lto=False set for all ECs. The restriction is only required when changing the toolchain so move the check down and add a...

Add optimal optimization flags for Intel compilers on AMD CPUs

5

We have the following code for Intel toolchains: ``` # used when 'optarch' toolchain option is enabled (and --optarch is not specified) COMPILER_OPTIMAL_ARCHITECTURE_OPTION = { (systemtools.X86_64, systemtools.AMD): 'xHost', (systemtools.X86_64, systemtools.INTEL):...

Avoid using a priority in prepend_module_path (Lmod) to avoid costly module calls

6

This PR avoids using a priority in `prepend_module_path` (Lmod) which means that $MODULEPATH can be directly modified by this and all subsequent calls to either `prepend_module_path` or `use` which is...

Don't use priority for module use

2

See https://github.com/easybuilders/easybuild-framework/pull/3557, especially: > We have a function prepend_module_path with an optional priority. Hence if we don't pass a priority then this function will not "prepend" the path Especially for...

Problem using CPATH in modulefiles overwriting system paths

13

TLDR: Stop setting CPATH in module files and set `C_INCLUDE_PATH, CPLUS_INCLUDE_PATH, INCLUDE` instead This came up for ROOT and was work-arounded in https://github.com/easybuilders/easybuild-easyblocks/pull/2047 Basically: the C/C++ preprocessor considers the paths...

Fix import of multiple easyblocks

4

Continuation of #3780 as fixing the issue with single PRs is much easier then messing with all this import stuff Additionally fixes including easyblocks from multiple PRs and the manipulations...

CMake and Boost are moving to targets. Hence if you want to use e.g. Boost.ProgramOptions you have to `target_link_libraries(target PUBLIC Boost::program_options)` which always works However here you only link the...

Especially in https://github.com/Illumina/manta/blob/75b5c38d4fcd2f6961197b28a41eb61856f2d976/src/cmake/cxxConfigure.cmake there are many instances of `if (${})` which is VERY problematic and must be replaced by `if(var)` instead. Similar for things like `if (${CMAKE_CXX_COMPILER_ID} STREQUAL "GNU")` which...

libdivsufsort breaks GNUInstallDirs

1

Look at https://github.com/simongog/libdivsufsort/blob/22e6b23e619ff50fd086844b6e618d53ca9d53bd/CMakeLists.txt#L30-L48 This sets cache variables to empty, then (if empty) sets local variables to a default but leaving the cache variables empty. Those local variables will only be...