Alexander Grund

Introduce folder-structure for coverage overview

1

It would be great, if you could show the files in a folder structure so one can browse the repo folder by folder and see the coverage per folder and...

For the function `src_callback_read` the documentation on what is reported on error is inconsistent. - https://github.com/erikd/libsamplerate/blob/7dcc9bb727dae4e2010cdc6ef7cda101b05509a4/src/samplerate.h#L90 says `-1` - https://github.com/erikd/libsamplerate/blob/7dcc9bb727dae4e2010cdc6ef7cda101b05509a4/doc/api_callback.html#L157 says `zero` but also zero when there is no more...

Undefined behavior due to shifts on signed integers

16

As found in https://github.com/erikd/libsamplerate/issues/65#issuecomment-516058420 using bit shifts on signed integers is undefined behavior. Reason for that is the difference between a "regular shift" (shr) and "arithmetic shift" (sar) where the...

Include version in public header

11

It would be helpful for consumers to know the version of the library during compilation. So I propose to define at least `LIBSAMPLERATE_VERSION` in `samplerate.h`. A good way done by...

I ran into the issue, that my file did not exists. The assert upload command simply said "skipped" and returned "OK" (exit code 0) which is wrong. Could it return...

Compile failure due to unconditional use of if-defed my_realloc_ALGD

1

There is an `my_realloc_ALGD` overload that takes `unsigned` values at https://github.com/liquidSVM/liquidSVM/blob/da19280562f443ab2b1fca898862f76c4ebc0bbd/sources/shared/system_support/memory_allocation.h#L86 which is not available if `SYSTEM_WITH_64BIT` is not defined: https://github.com/liquidSVM/liquidSVM/blob/da19280562f443ab2b1fca898862f76c4ebc0bbd/sources/shared/system_support/memory_allocation.h#L81 However that overload is always used: https://github.com/liquidSVM/liquidSVM/blob/da19280562f443ab2b1fca898862f76c4ebc0bbd/sources/svm/solver/basic_svm.cpp#L166 with `used_size`...

Fixes #8

https://github.com/liquidSVM/liquidSVM/blob/03df5c8841dac0466cb7a7f487e44e82858832f6/sources/shared/system_support/memory_allocation.h#L45 uses the lower-case `__ppc64__` which is not defined by GCC (check 8.3.0) and hence fails compilation due to #7 I suggest to use `__PPC64__` instead or additional

It is currently not possible to pass custom flags to the CUDA compiler. E.g. on Power9 archs the compiler throws the following error: ``` nvcc -I... -arch sm_30 -L... -DCOMPILE_WITH_CUDA__...

Mixed Mesh Layouts: Same or Different Files?

2

When running PIC-Simulations one may also have records that are not fields. E.g. running a Photon-Scatter-Simulation with Photons (particles), Field (electron density) and Detector (2D record) The current version of...