easybuild-framework icon indicating copy to clipboard operation
easybuild-framework copied to clipboard

Published 20 hours ago • verified publisher icon easybuilders

remove code that was required to support Python 2.6

Open Flamefire opened this issue 3 years ago • 5 comments

As Python <2.7 support was dropped in EasyBuild 4.4 (see #3715) I cleaned up the code that supports 2.6 which means removal of OrderedDict as well as some more unittest/CI code

Additionally I fixed the known issue that installing EB in Python3 shows a syntax error warning.

Flamefire avatar Jul 28 '21 13:07 Flamefire

Apart from that I think this is good enough. @boegel do you want a deprecation warning for HgRepository?

akesandgren avatar Dec 07 '21 12:12 akesandgren

Rebased and updated. Please review.

Flamefire avatar Jul 26 '22 13:07 Flamefire

Hmmm, this one has conflicts again...

akesandgren avatar Feb 13 '23 07:02 akesandgren

Since we're doing a broader code cleanup in #4229 for the upcoming EasyBuild 5.0, I'm not sure it's worth the effort to get this PR merged for EasyBuild 4.x...

boegel avatar Apr 12 '23 16:04 boegel

Since we're doing a broader code cleanup in #4229 for the upcoming EasyBuild 5.0, I'm not sure it's worth the effort to get this PR merged for EasyBuild 4.x...

Why not? Rebased again and it is pretty simple removing some dead code which should make updates here easier.

Flamefire avatar May 11 '23 07:05 Flamefire