Finomnis

Results 130 comments of Finomnis

@korken89 Bump :)

> Is this planned for merging or is there still discussion or more to do? Planned for merging, waiting for a review.

> Some minor comments Busy at work RN, might take a look later :)

@korken89 Fixed

> @Finomnis Could you please rebase on latest master branch and while doing that remove all merge commits? > > Might also be a good opportunity to tidy a bit...

> Why have you downgrade esp32c3 version? My bad. Merging gets out of hand with these kind of huge merge requests. I hope it is merged soon.

@AfoHT Is it alright with you if we squash merge, instead of me cleaning up the commit history?

@korken89 Did some minor fixes after merging the main branch, should be stable again

Don't use async Mutexes for short-lived locks like this. Use a normal `std` mutex instead. See [this section of the tokio book](https://tokio.rs/tokio/tutorial/shared-state#on-using-stdsyncmutex) for more information.

My plan is currently to implement purely the `async` version and convert them to blocking with the `cassette` crate. I do have quite some experience with async (I'm the owner...