rtic icon indicating copy to clipboard operation
rtic copied to clipboard

Published 20 hours ago • verified publisher icon rtic-rs

Monotonic rewrite

Open Finomnis opened this issue 1 year ago • 3 comments

See #873.

Finomnis avatar Dec 27 '23 16:12 Finomnis

Hi @Finomnis , sorry for the delay on this!

Overall it looks like a very nice improvement of the monotonics. Would you like to cleanup the PR to get tests to start passing? And please give us a ping when we can test it more :D

korken89 avatar Jan 31 '24 19:01 korken89

@korken89 Hey! Sorry for the delay, I was kinda busy with family and stuff. I'll start working on this now again, looking forward to your feedback.

Finomnis avatar Feb 25 '24 11:02 Finomnis

@korken89 Bump :)

Finomnis avatar Mar 04 '24 15:03 Finomnis

Is this planned for merging or is there still discussion or more to do?

misterinterrupt avatar Mar 11 '24 21:03 misterinterrupt

Is this planned for merging or is there still discussion or more to do?

Planned for merging, waiting for a review.

Finomnis avatar Mar 12 '24 07:03 Finomnis

Awesome, I like what you've done and looking forward to it

Is this planned for merging or is there still discussion or more to do?

Planned for merging, waiting for a review.

misterinterrupt avatar Mar 12 '24 07:03 misterinterrupt

We just merged a large RISC-V support PR that has minor clashes with this PR, could you rebase?

korken89 avatar Mar 20 '24 20:03 korken89

Some minor comments

Busy at work RN, might take a look later :)

Finomnis avatar Mar 21 '24 08:03 Finomnis

@korken89 Fixed

Finomnis avatar Mar 21 '24 21:03 Finomnis

@Finomnis Could you please rebase on latest master branch and while doing that remove all merge commits?

Might also be a good opportunity to tidy a bit in the commit log 😇

If unsure how, I'm happy to help 👍

AfoHT avatar Apr 04 '24 08:04 AfoHT

@Finomnis Could you please rebase on latest master branch and while doing that remove all merge commits?

Might also be a good opportunity to tidy a bit in the commit log 😇

If unsure how, I'm happy to help 👍

I planned to do a squash merge, if that's allright. I'm too lazy to clean them up :D

Finomnis avatar Apr 05 '24 14:04 Finomnis

Why have you downgrade esp32c3 version?

burrbull avatar Apr 07 '24 08:04 burrbull

Why have you downgrade esp32c3 version?

My bad. Merging gets out of hand with these kind of huge merge requests. I hope it is merged soon.

Finomnis avatar Apr 07 '24 08:04 Finomnis

@AfoHT Is it alright with you if we squash merge, instead of me cleaning up the commit history?

Finomnis avatar Apr 07 '24 09:04 Finomnis

@korken89 Did some minor fixes after merging the main branch, should be stable again

Finomnis avatar Apr 09 '24 00:04 Finomnis

@Finomnis don't worry about the esp32c3 QEMU run :)

I'm in the process of squashing/tidying the PR which is about to be merged

But if you got more commits coming I can hold off a little, or we just create another PR. What do you think?

I'll bring in the https://github.com/rtic-rs/rtic/pull/874/commits/986f9594709c936605c7a42b69182d3b3c21b199 onto the squashed/rebased WIP I got :)

AfoHT avatar Apr 10 '24 20:04 AfoHT

I took the liberty of tacking on a tiny CI fix, to get CI happy enough for a merge :)

AfoHT avatar Apr 10 '24 21:04 AfoHT

Very nice

SpinFast avatar Apr 22 '24 13:04 SpinFast