Philippe Rivière
Philippe Rivière
🤔 We don't support -0 anywhere else, so this introduces an incongruity. For example, if the value we need to stack is the output of an aggregation with a "sum"...
(Also re-reading this code I wonder why compare is in its own loop, and reverse is not. For readability, could we move compare just above reverse, or vice-versa?)
My (very unimaginative) unit test: ``` export async function stackZeroes() { const data = Array.from({length: 100}, d3.randomNormal.source(d3.randomLcg(42))()).map((value, i) => ({ value: i % 7 === 0 ? 0 : value,...
I've spent a moment trying to understand the situation you're describing, but I don't get it. Seems to me that (EDIT: _with my suggested patch_) zeroes in a stack of...
I've edited my comment above to clarify that it relates to my suggested patch.
Agree that if the user passes -0 it is logical to stack it on yn. But should we _depend_ on this peculiar value to answer the OP? It feels like...
Thanks! Do you want to make a pull-request with this change? I think it should have a sentence to say "optionally, create a `sql` symbol to use elsewhere in the...
Yes, please review 🙏
You don’t need any special power to test this PR against real life use cases, read the code and try to find conditions that will make it break , etc....
We are currently seeing AI-generated PRs and don't want to spend time considering them. It's difficult to know for sure whether that is the case for that PR, and I'm...