d3-contour icon indicating copy to clipboard operation
d3-contour copied to clipboard

clamp to the edge

Open Fil opened this issue 1 year ago β€’ 8 comments

To avoid cutting the corners (#72), expand the data on the edges by 1 pixel (with the addition of a bit of blurring); then contract the shape back to the frame. Note that we must contract after smoothing.

closes #72

Fil avatar Nov 26 '24 10:11 Fil

@Fil Sorry, is this PR abandoned or is it still awaiting review?

DanielCordell avatar Mar 11 '25 15:03 DanielCordell

Yes, please review πŸ™

Fil avatar Mar 11 '25 16:03 Fil

Yes, please review πŸ™

I don't believe I have the power, @mbostock please could this get blessed with a review πŸ™?

DanielCordell avatar Mar 11 '25 17:03 DanielCordell

You don’t need any special power to test this PR against real life use cases, read the code and try to find conditions that will make it break , etc. :)

Fil avatar Mar 11 '25 18:03 Fil

@Fil I personally can't spot any issues but I wouldn't exactly call myself an expert on this. I'm using this for a work process and we can't use node/npm or any alternative (self-hosting the d3 UMD .js file in vanilla JS), so I can't build it myself either to test πŸ˜† .

DanielCordell avatar Mar 20 '25 09:03 DanielCordell

@mbostock is there any chance you could please take a look/review this change? It's been outstanding for ~5 months.

DanielCordell avatar Mar 24 '25 15:03 DanielCordell

@Fil what's the plan here πŸ˜† it would be really amazing if we could get this change in, do you know anyone who can review?

DanielCordell avatar May 07 '25 10:05 DanielCordell

I have been using this, as a patch, for some days and it seems to work well on our data (small and medium size)

MattiasJa avatar Sep 25 '25 07:09 MattiasJa