Yohan Belanger

Results 19 comments of Yohan Belanger

I've also noticed that some parameters could be seen as subsets of other parameters. Merging then could shrink the size of the param struct. The image was used for another...

The way we usually handle problems with thread repeatability is implementing a safe parallel thread for statement. Something that can easily be used across the whole code for safe thread...

Finally it would be a good thing to explain which parameters are mandatory... I'm having a hard time figuring this one out from the code only.

Especially this part because in the documentation the admin file in not enclosed in brackets but in the param loop theres no check for it https://github.com/mrc-ide/covid-sim/blob/01010f52a3a4e2cc8eaa09d144ad21bd1ea88c22/src/CovidSim.cpp#L164

There are no mention of the kernel strenght in the documentation also https://github.com/mrc-ide/covid-sim/blob/01010f52a3a4e2cc8eaa09d144ad21bd1ea88c22/src/CovidSim.cpp#L184

@ozmorph Do you think I can do a pull request of the program_options code I did to replace the very complex parsing at the beginning of the main? When it...

@ozmorph Of course! https://github.com/Feynstein/covid-sim https://github.com/Feynstein/covid-sim/blob/master/CovidSim.cpp What you want to look at is my main... Its been changed a lot and I upgraded to C++17 in order to use the std::any...

Oh and in my CMake Lists I added an automatic out-of-source -git-branch-related-debug/release build, so that when you get in there you only have to do "cmake ."

And I already sent an email from my university account to @weshinsley in order to see if I could be an official scientific contributor...