covid-sim icon indicating copy to clipboard operation
covid-sim copied to clipboard

Make parameter handling more robust

Open matt-gretton-dann opened this issue 4 years ago • 1 comments

Command line option handling and reading of input files do not give helpful errors when inputs are incorrect. This issue is to work through some of these and improve command-line and input file parsing. Ideally adding unit/regression tests as we go:

  • [ ] Ensure for command line options taking an input file name we check the file exists
  • [ ] Make parameter file handling robust:
    • [ ] When using values passed via /CLP#: erroring if /CLP# wasn't specified on command line
    • [ ] Issuing warnings about what options weren't used.
    • [ ] Issuing warning if we can't parse the value for a parameter
    • [ ] Highlighting where one value overrides another
    • [ ] Enable output of a parameter file which merges all values read.

matt-gretton-dann avatar Apr 09 '20 14:04 matt-gretton-dann

I've also noticed that some parameters could be seen as subsets of other parameters. Merging then could shrink the size of the param struct. The image was used for another issue but you can see some of those parameters that could be aggregated, or placed in some sort of hierarchy structure. 81463760-072b1600-918a-11ea-817f-93012f1887af

Feynstein avatar May 09 '20 04:05 Feynstein