Fedir Zinchuk
Fedir Zinchuk
I have tested this item :white_check_mark: successfully on 6fd6fcb03abb2e18f66c8319320d36df405ad2ecThis comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37174.
I have tested this item :white_check_mark: successfully on 8b05ef3365f0303c0d226e1d9ada114720310805This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37174.
HTML supports only string value, so no boolean values. You cannot do `` and expect it will be a boolean, it will be a string `false`. The same for Joomla...
Would be good to have an option to keep the `content` value unchanged. Currently ```js let { code } = transform({ code: Buffer.from(` .foo:before { content: "\\31"; } .bar:before {...
Looks fine, if it works :)
> it should be info not warning It is "notice", as it was before in 5.0 and in j4.
tbh, this messages is useless, why do we have them in first place? Only a warning about disabled plugin is good enough.
It is (almsot) 1:1 copy of what was before: Old: https://github.com/joomla/joomla-cms/blob/301bdf2b2879277e66693f7c4ce62d9265d18462/administrator/components/com_redirect/src/Controller/DisplayController.php#L54-L77 New: https://github.com/joomla/joomla-cms/blob/b947df6d05cc10d87ac6dce76d6cf9e30e661266/administrator/components/com_redirect/tmpl/links/default.php#L34-L67 Maybe something wrong with redirectPluginId or with that if() condition, who knows.
> redirectPluginId gets the ID of the plugin It is there only when the plugin is disabled https://github.com/joomla/joomla-cms/blob/a1cdbc1df055f325061ef92274587e9479f5f443/administrator/components/com_redirect/src/View/Links/HtmlView.php#L139-L141
> I give up Don't give up