Fedir Zinchuk

Results 332 comments of Fedir Zinchuk

I have noticed to late. Can you please do not do redirect in `parseRule`? The rule should do "rule thing", nothing more. The same problem with https://github.com/joomla/joomla-cms/pull/42702 (that already merged...

I have tested this item :white_check_mark: successfully on 58f6055724a9da2faec4320d31b47b114a9edd79This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40131.

BTW, it can be done in backward compatible way, without new method and new param. Just add a new property to the `TagsHelper`, and use it. ```php $tagsHelper->removeTags = true;...

Nope https://github.com/joomla/joomla-cms/blob/d272577bbbc636284305538e2d76ba48a7a6b933/administrator/components/com_fields/src/Helper/FieldsHelper.php#L179-L185 Every time you call `FieldsHelper::getFields` it will load new values.

I have tested this item :white_check_mark: successfully on 93a3fb533ef8f9fb12535c5876119e3fd67ba255This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42762.

I have tested this item :white_check_mark: successfully on b94e597bdff0bffb221f02a6dd582c090486fd30This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42761.

> Do you see also an option to add the user parameters as an extra layer I thought about it, but I would make it in separated PR. We need...

> can't we do this in a generic way? maybe with a module and joomla w-c and event trigger and not only for atum? You mean for User specific? Yeah,...

> So: more work needed? yes, this part is in the description under "SCSS fixes needed" title, I have a hope it will be fixed in #42010, but not sure...

The style fix will be there: - https://github.com/joomla/joomla-cms/pull/42757 Current PR povides only the switch feature.