Fedir Zinchuk

Results 332 comments of Fedir Zinchuk

Okay, I thought you will change both :)

> no idea why it's not the same as the plugin description it is dinamicaly generated here https://github.com/joomla/joomla-cms/blob/febdab61581ffdffb941db3aa7dd368bc083a30e/build/media_source/plg_system_shortcut/js/shortcut.es6.js#L103-L114

Yeah, well, not trivial, require new string for `Joomla.Text._('then')` :)

It comes from plugin https://github.com/joomla/joomla-cms/blob/f520c98c64efb538e70e918acffb60d07e4d6b1e/plugins/system/shortcut/src/Extension/Shortcut.php#L119-L139 > why doesn't it take the existing language override? The modal shows User defined combination, and so the modal content is dinamicaly generated.

> The modal shows User defined combination, I mean combination that may come from other extennsion with `addShortcuts` event,

This will do the thing ```javascript dl += ` ${Joomla.Text._('JTHEN')} ${key.trim()}`; ``` Or full: ```javascript let dl = ''; dlItems.forEach((titles, shortcut) => { dl += 'J'; shortcut.split('+').forEach(key => { dl...

But probably, it is fine as you already made, it is less confusing on dashboard now.

@coolcat-creations I think @brianteeman is right, better remove `` on first letter, There not always will be a case when first letter will refer to "shortcut", especialy for non Eglish...

Almost :wink: ![image](https://user-images.githubusercontent.com/1568198/188087637-ee8ad555-6322-41a1-888a-e9cf74fe8bac.png)

Add new js string around here: https://github.com/joomla/joomla-cms/blob/f520c98c64efb538e70e918acffb60d07e4d6b1e/plugins/system/shortcut/src/Extension/Shortcut.php#L94-L97 ``` Text::script('PLG_SYSTEM_SHORTCUT_THEN'); ```