Fabian Fröhlich

Results 273 comments of Fabian Fröhlich

I don't think there are any simple conversion functions as a `ReturnDataView` is a relatively complex class with caching ane attributes that are C pointers. Wouldn't it be sufficient to...

> > I don't think there are any simple conversion functions as a `ReturnDataView` is a relatively complex class with caching ane attributes that are C pointers. Wouldn't it be...

Yes, will have to add more versatile creation of RData instances for other purposes anyways.

> I see the mix-up. `kwargs: dict` in the docstring means that kwargs is a `dict`, it does not say anything about the type of keys or values in the...

> Then, do you know if `dict[str, object]` would be treated better? It is treated the same, so it interprets that the values should be dicts.

Oh sounds nice, didn't know about xarrays!

> `rm -rf /var/lib/apt/lists/*` limits downstream reusability though and only saves ~200B, see https://gist.github.com/marvell/7c812736565928e602c4

cancel requests would also allow you to cancel a complete evaluation once evaluation on a single dataset fails ;)

> LGTM overall, though it's been a while since I worked with compartments. Ideally it'd be good to see test coverage for the two lines highlighted by codecov - particularly...