Fabian Fröhlich

Results 273 comments of Fabian Fröhlich

> Optimizing a single parameter from multiple models could require a mapping of the parameters, because the parameters do not have to be named identically in the different models (especially...

> While I am happy to get rid of the `problems` list in the yaml file for the single-model case, I thought the editor meeting discussion ended with going back...

> I think it looks good, left a minor comment. > > Probably outside the scope of this PR, but it can be worthwhile to somewhere note down how to...

> I think, the suffix was intended to reduce the chances of collision with already exiting parameters with a different purpose. (Not saying that it would be a good idea...

> > Well if it's only about collisions they could just universally be renamed to `observableParameter1_placeholder`. > > In principle, yes. (Or even shorter, `placeholder$n`.) > > However, the problem...

What's the point of having globally unique placeholders? Apart from time-point specific overrides (which is rare, as far as I know) everything else could be achieved by overriding scales/offsets in...

> > What's the point of having globally unique placeholders? > > It might be more convenient for annotations (e.g., units). Fair. > > Apart from time-point specific overrides (which...

This is already mostly covered by https://github.com/AMICI-dev/AMICI/pull/2840

I thought starting in a root would throw an error. Probably the best way to handle this is start the simulation at 0+eps, but that will make it difficult to...

Maybe we should plan towards making a 1.0.0 version with some other breaking changes