FANNG

Results 47 comments of FANNG

> > How about Override `loadTable(Identifier ident, String version)` and `loadTable(Identifier ident, String version)` for `GravitinoIcebergCatalog`? > > in this way, we still have the problem of initializing the `snapshotId`...

yes, but we planned to do this after the basic feature of the spark-connector is set up. If you're interested, you could do some work.

Time sliding window based metrics is more suitable for our scene, no need to make it configurable. 60s time window seems enough , @jerryshao do you think is it neccessary...

> I think it would be better to make the time window configurable. ok

@jerryshao , please help to review when you are free

@jerryshao , @jerqi , please help to review again when you are free

> @FANNG1 I think I have already rebased the main branch. But the GitHub CI still failed. Can you help me with it? Thanks. seems CI failure are cause by...

LGTM, except few comments, @jerryshao do you have time to review the PR?