gravitino icon indicating copy to clipboard operation
gravitino copied to clipboard

Published 20 hours ago • verified publisher icon apache

[#3152] fix(core): using time sliding window to record timer metrics

Open FANNG1 opened this issue 9 months ago • 4 comments

What changes were proposed in this pull request?

using time sliding window to record timer metrics

Why are the changes needed?

Fix: #3152

Does this PR introduce any user-facing change?

no

How was this patch tested?

test in local env to check whether Pxx comes to 0 after a while

FANNG1 avatar May 11 '24 10:05 FANNG1

Time sliding window based metrics is more suitable for our scene, no need to make it configurable.
60s time window seems enough , @jerryshao do you think is it neccessary to make it configurationable ?

FANNG1 avatar May 13 '24 08:05 FANNG1

I think it would be better to make the time window configurable.

jerryshao avatar May 15 '24 02:05 jerryshao

I think it would be better to make the time window configurable.

ok

FANNG1 avatar May 15 '24 03:05 FANNG1

@jerryshao , please help to review when you are free

FANNG1 avatar May 16 '24 10:05 FANNG1

@TEOTEO520 can you please help to check if the fix here satisfy your needs?

jerryshao avatar May 17 '24 09:05 jerryshao

@jerryshao , @jerqi , please help to review again when you are free

FANNG1 avatar May 20 '24 06:05 FANNG1