gravitino icon indicating copy to clipboard operation
gravitino copied to clipboard

[#3362] feat(flink-connector): support GravitinoCatalogStore to register the catalog

Open coolderli opened this issue 1 year ago • 4 comments

What changes were proposed in this pull request?

  • support GravitinoCatalogStore to register the catalog. In the MR, we will support to create the hive catalog.

Why are the changes needed?

  • Fix #3362

Does this PR introduce any user-facing change?

  • support flink in gravitino

How was this patch tested?

  • add UTs

coolderli avatar Mar 22 '24 06:03 coolderli

@coolderli can we please move forward the flink support?

jerryshao avatar May 13 '24 06:05 jerryshao

@coolderli can we please move forward the flink support?

@jerryshao Of course. I will finish the first one today.

coolderli avatar May 13 '24 07:05 coolderli

@jerryshao @FANNG1 Could you please help view this? Thanks.

coolderli avatar May 13 '24 10:05 coolderli

@FANNG1 I have updated the MR. Please help review it when you have time. Thanks.

coolderli avatar May 16 '24 08:05 coolderli

@FANNG1 Could you help review this MR again? Thanks.

coolderli avatar May 20 '24 09:05 coolderli

@FANNG1 I think I have already rebased the main branch. But the GitHub CI still failed. Can you help me with it? Thanks.

coolderli avatar May 20 '24 10:05 coolderli

@FANNG1 I think I have already rebased the main branch. But the GitHub CI still failed. Can you help me with it? Thanks.

seems CI failure are cause by #3390 which change the API about metalake and catalog operations. You could refer the latest the implement of Spark GravitinoCatalogManager for the usage.

FANNG1 avatar May 20 '24 11:05 FANNG1

@FANNG1 I have fixed the pipeline. Please help review again. Thanks.

coolderli avatar May 22 '24 10:05 coolderli

@FANNG1 Address all comments. Please review it again. Thanks a lot.

coolderli avatar May 22 '24 12:05 coolderli

LGTM, except few comments, @jerryshao do you have time to review the PR?

FANNG1 avatar May 23 '24 08:05 FANNG1

@FANNG1 You can go ahead if you feel OK. Thanks @coolderli for the first step of Flink support.

jerryshao avatar May 23 '24 08:05 jerryshao

@coolderli , thanks for proposing the base PR for Flink, a big step!

FANNG1 avatar May 24 '24 04:05 FANNG1